GurliGebis / WoWAddon-AngrierWorldQuests

30 stars 14 forks source link

Feature Request: Indication on world quest not completed by warband #62

Closed Zaazu closed 2 days ago

Zaazu commented 2 weeks ago

Since the release of the Warband feature, world quests now offer a bonus the first time you complete them. I think it would be nice if there was some way to easily see which world quests have already been completed by a character.

image

I was thinking either use an underline to show that world quest has not been completed yet: 1

or desaturated text for world quests that have been completed: 2

GurliGebis commented 2 weeks ago

I like your idea 🙂 I will see if there is a way to query if there is a bonus for a WQ

GurliGebis commented 5 days ago

I have unlocked world quests now - but I cannot find any with this message on them. Also, from what I can see, it looks like you might be able to query if quest has this bonus enabled (Haven't been able to find it yet, but it should be there). However, I fear that once that has been completed on a WQ, it just appears to the system as if it didn't have a bonus at all. (Like there is no difference between quests without a bonus and quests that had a bonus but has been completed)

Zaazu commented 4 days ago

The world map must be getting that info from somewhere.

World Map: image

Angrier World Quests: image

CruelDrool commented 4 days ago

Try adding this in Modules/QuestFrame/QuestFrameModule.lua, on line 414:

button.questRewardTooltipStyle = TOOLTIP_QUEST_REWARDS_STYLE_WORLD_QUEST
GurliGebis commented 3 days ago

Okay, that works, and it also pointed me in the right direction C_QuestLog.QuestContainsFirstTimeRepBonusForPlayer 🙂 However, I still have two problems (please let me know if you have any ideas):

1: WQs before TWW does not have bonus, so they all return false, which would color them as well - any ideas on how to avoid that? 2: Not all WQs has a bonus - so they would be grey, even if they have never been completed - there doesn't seem to be a way to detect this.

I'll release the change with the tooltip in the next release shortly, but the rest I don't know how to fix.

Zaazu commented 3 days ago

The warband bonus in tooltip was a good change, thanks. How about an extra icon showing the bonus next to the other rewards? Although, with the tooltip change it's not as needed anymore.

Quick Mockup: image

In case you're wondering, the green arrow I used is: interface/containerframe/bags bags-greenarrow

It's up to you whether you want to add this feature, I'm happy either way.

GurliGebis commented 3 days ago

How about coloring them with a different color, if there is a bonus? That way, the reward text will still be aligned 🙂

Zaazu commented 3 days ago

Sounds good, there's already a red text world quest for something, a world boss I think.

GurliGebis commented 3 days ago

This is what I ended up with (reusing the same color as the "Awards...." text 🙂

billede

Zaazu commented 2 days ago

Looking real nice 🙂

GurliGebis commented 2 days ago

I have just pushed 11.0.2-20240912-1 - if you install it, and then enable the option Color World Quests with Warband bonus blue, it should work 🙂