request pet tracker in quest tracker

Nutrition1 commented 6 months ago

Love it if you could add a missing pet tracker into the quest tracker like "pettracker" addon does love it when i go into a zone and it shows im missing pets from it! Love the addon otherwise!!

GurliGebis commented 6 months ago

Thanks, I think the #11 work, once it is done, should be a great start for this. So it is on the todo list 😊

davidmc24 commented 6 months ago

I've been running with my implementation-in-progress of #11 for a week or two now, and it does indeed seem to fill that role well. I'll try to get a first pass packaged up as a PR this weekend.

Nutrition1 commented 6 months ago

Sounds great! If I can suggest something "pet tracker" addon didn't have. Any options on the tracker it was just track pets in zone that you had, what rarity and level they are. Being a pet collection I'm not too bothered by level or rarity so I'd go into a zone with it still tracking even though I had all the pets just because they weren't max level or blue rare.

GurliGebis commented 6 months ago

I think following the filtering for the map would make sense. So if you are filtering the map icons with Missing, only missing are shown in there as well.

davidmc24 commented 6 months ago

There are a couple different directions we could go here that I've experimented with:

A short string as a LibDataBroker data source; we can use this to show progress towards a single filter/goal, such as "5/6"
- We'd either need configuration to control which goal, or expose multiple DataBroker sources such that the user could enable what they want through their data display addon's configuration. The latter approach would allow users to have at-a-glance visibility to multiple values of desired. For example, a user might want to see progress on rare pets in the zone and their overall pet score
A tooltip shown when you hover over the LibDataBroker data source.
- This is probably best used for quick details related to the data shown in the data source; for example, if your goal is "max rare" and the data source is showing 3/6 for the zone, the tooltip might show information about which 3 pets in the zone you don't have max rare for yet.
A separate "goal tracker" window
- This could be shown on-demand by clicking the data source, or left up all the time
- For comparison, PetTracker integrated this style of information into the quest/achievement tracker (which I didn't much care for, as it made it hard to see when you're multi-tasking pet collecting and achievement progress)
- This can be used for more detailed visibility about goals
- It feels more natural to use things like tabs and scrolling here than in a tooltip, potentially allowing things like quickly switching between a goal-specific tab and an "all" tab to get more information about what could be farmed, even if you've already collected it.

Some screenshots of my WIP (which still has a ways to go)

Data broker in upper-left (currently showing "max rare" mode)

Data broken with tooltip hovered in upper-left (currently showing "max rare" mode)

Goal tracker window one collected tab

Goal tracker max rare tab

Goal tracker all tab

It isn't visible in the screenshots, but the goal tracker window does support vertical scrolling for zones with lots of pets. I haven't implemented any of the controls for the goal tracker to enable resizing/positioning/display at login/etc.

I also expect that if we go with a tabbed goal tracker window, we'd want a couple additional tabs, such as "one rare" and "max collected", to match our filters.

GurliGebis commented 6 months ago

I like the separate window idea too 🙂

Nutrition1 commented 6 months ago

defo separate window same situation here I find quest + achievement tracker could be overwhelming. Love the idea of the tooltip as well.

davidmc24 commented 6 months ago

A brief status update: the broker data source and tooltip window have been merged. I'm working on an unrelated PR next (support for migrating configuration and cleaning up the config a bit) after which I'll get back to my work on the separate window.

GurliGebis commented 6 months ago

@davidmc24 thank you - I really appreciate you helping out improving my small addon.

swotam commented 2 months ago

I like the Goal Tracker window idea, but would also appreciate optional integration with the Objective Tracker. I use a quest log addon named Kaliel's Tracker which specifically has a selectable integration option for Pettracker that would allow missing pets to appear at the bottom of the objective tracker in a separate collapsible list, however both addons are currently not updated for 11.x.

Also curious if there's an update on when the addon may be updated to support the separate window? It's been several months since the last update.

davidmc24 commented 2 months ago

Sorry for the delay. I got distracted by remix. I'll get back to working on that.

davidmc24 commented 2 months ago

https://github.com/GurliGebis/WoWAddon-BattlePetCompletionist/pull/44

GurliGebis commented 2 months ago

Thanks @davidmc24 - I have pushed 11.0.2-20240815-1 with this. We can always expand on it later on, to add more functionality 🙂 @Nutrition1 can you give it a try and let us know what you think?

swotam commented 2 months ago

Initial implementation of the goal tracker looks good. One issue I've noticed is that, if the tracker isn't visible on screen, when you left click on the BPC icon it doesn't open the tracker window. You have to click the BPC icon again to have the tracker window open. Closing by left clicking seems to work properly.

Put another way, you have to left click twice on the BPC icon to open the tracker, but only once to close it.

I'm using the icon in the Blizzard addon container if that matters.

davidmc24 commented 2 months ago

Thanks for calling that out. I'll take a look at the tracker opening behavior tonight.

davidmc24 commented 2 months ago

@GurliGebis @swotam Fix PR here: https://github.com/GurliGebis/WoWAddon-BattlePetCompletionist/pull/49

Nutrition1 commented 2 months ago

issue with icon not be correctly in frame. It doesnt seem to show any details of the collected pets?

GurliGebis commented 2 months ago

@davidmc24 I have pushed 11.0.2-20240821-1 with your two pull requests merged.

davidmc24 commented 2 months ago

@Nutrition1 If you mean the X icon in the upper-right, then yes, I agree that it looks wonky, but it's also an AceGUI thing that should be fixed upstream.

https://www.wowace.com/projects/ace3/issues/623

Not showing info on collected pets is currently intentional, but something we can consider changing in the future as we add further capabilities/options.

zalidthebur commented 1 month ago

What would be nice, imho, is if we had an option to have the goal tracker auto show in any zone missing a pet.

GurliGebis / WoWAddon-BattlePetCompletionist

request pet tracker in quest tracker #22