search

GurliGebis / WoWAddon-BattlePetCompletionist

GNU General Public License v3.0
6 stars 2 forks source link

Add data broker support #23

Closed davidmc24 closed 5 months ago

davidmc24 commented 5 months ago

This is intended to address both https://github.com/GurliGebis/WoWAddon-BattlePetCompletionist/issues/11 and https://github.com/GurliGebis/WoWAddon-BattlePetCompletionist/issues/22 when it's done.

Submitting as a draft to allow feedback during development... and ask questions on parts I may be unclear on.

GurliGebis commented 5 months ago

I will take a look at the code tonight hopefully (I'm at GMT+2 right now) and test it 🙂

davidmc24 commented 5 months ago

This looks pretty good to me. I was considering adding some form of enum pattern so that goal config values could easily be referenced in a safer way than as string constants, but thus far I haven't found a way that would work cross-file (in my IDE) without polluting the global namespace.

GurliGebis commented 5 months ago

This looks pretty good to me. I was considering adding some form of enum pattern so that goal config values could easily be referenced in a safer way than as string constants, but thus far I haven't found a way that would work cross-file (in my IDE) without polluting the global namespace.

I will take a final look at it later today, and give it a test.

GurliGebis commented 5 months ago

@davidmc24 Thanks - I have merged and released 10.2.6-20240418-1 Can you take a look at the cleanup things we talked about in a new branch?