GurliGebis / WoWAddon-BattlePetCompletionist

GNU General Public License v3.0
6 stars 2 forks source link

Avoid excessive cpu usage from repeated zone change events #32

Closed davidmc24 closed 4 months ago

davidmc24 commented 4 months ago

Addresses https://github.com/GurliGebis/WoWAddon-BattlePetCompletionist/issues/31

GurliGebis commented 4 months ago

Thanks, I'll make one small change (move the then in the if statement to the same line) and then merge it. As always, really appreciate your help 🙂

davidmc24 commented 4 months ago

Sounds good. The coding conventions in Lua really throw me off sometimes. I'm more accustomed to JavaScript/Java/C-style conventions.

GurliGebis commented 4 months ago

Hehe, yep, I really don't like the language (my background is in C# and C++, so not having classes seems "wrong"). Mostly it's just to keep it like the rest of the codebase 🙂