Gurobi / gurobi-optimods

Data-driven APIs for common optimization tasks
https://gurobi-optimods.readthedocs.io
Apache License 2.0
153 stars 32 forks source link

Line Optimization in Public Transport #132

Closed Marika-K closed 8 months ago

Marika-K commented 10 months ago

Description

A new optimod for line optimization in public transport.

There is currently no issue for this optimod but it is related to Network Design Optimod #36

Checklist

Have a nice day!

simonbowly commented 10 months ago

This looks awesome, thanks for the great work @Marika-K! The multi-objective component is a particularly nice feature.

@stevedwards in applications terms I think this quite different from the network design mod, and it would make sense to have both of them in the library separately. Thoughts?

stevedwards commented 10 months ago

Yeah, this is super, super nice. Love everything about it. The level of abstraction is perfect for an optimod. Yeah @simonbowly totally makes sense to have them separately. Great work @Marika-K

Marika-K commented 10 months ago

Thanks! I am happy that this Optimod fits. Do you know what the problem with test_portfolio.py could be?

simonbowly commented 10 months ago

Looks like a numerics problem, happens from time to time with that mod. It looks like all your tests are passing so nothing to worry about. Just mark this PR "ready for review" when ready!

Marika-K commented 8 months ago

Thanks, Simon! I updated the code and added some more exception handling. If you do not see any issues, I think I am done.

simonbowly commented 8 months ago

Looks good, thanks!

simonbowly commented 8 months ago

And again, great work @Marika-K! This is a really nice addition :-)