search

Guru-Digital-Archive / frontend-admin

A module for editing page content form the front end of your website using TinyMCE 4
BSD 2-Clause "Simplified" License
9 stars 7 forks source link

Editor is incorrectly applied on alt attribute #3

Closed russellshome closed 10 years ago

russellshome commented 10 years ago

E.g. alt="$SiteConfig.Logo.Title"

cjsewell commented 10 years ago

HTML attributes should be xml escaped E.g. alt="$SiteConfig.Logo.Title.XML"

This does a couple of things. First, it escapes any quotes or invalid attribute characters, also it prevents the Front End Editor from applying the editor to it.

Template developers should to this anytime they are using variables in html attributes

mikeyc7m commented 9 years ago

Make that $SiteConfig.Logo.Title.ATT

cjsewell commented 9 years ago

Indeed @mikeyc7m you are right. ATT is the correct one to use for html attributes