Gurupreet / ComposeCookBook

A Collection on all Jetpack compose UI elements, Layouts, Widgets and Demo screens to see it's potential

MIT License

6.3k stars 799 forks source link

refactor: Migrate instagram in a Gradle module. #71

Closed GerardPaligot closed 3 years ago

GerardPaligot commented 3 years ago

Motivation

Suggest a first implementation for multi module strategy for demo apps.

Changelog

Create :data module for fake data provider.
Create :theme module for all compose template resources.
Create :demos:instagram module for instagram demo app.

Issue #61

GerardPaligot commented 3 years ago

@Gurupreet Android build fixed here. ic_baseline_home_24 used colorControlNormal attribute in tint property but this icon is never used and (I think) this attribute shouldn't be used on the definition of the icon. I just removed the property. Hope it is ok.

Gurupreet commented 3 years ago

Thanks @GerardPaligot great work :)

GerardPaligot commented 3 years ago

Happy the structure is okay for you. I'll migrate others demos with the same structure in next days! :)

Gurupreet commented 3 years ago

Yes it's great and cleaner. Would be really nice if CryptoApp one and MovieApp one can be separated standalone module as they have MVVM/APIS etc with them 💯

GerardPaligot commented 3 years ago

challenge-accepted-barney-5619