search

Gustaf-C / anki-chinese-support-3

Anki add-on providing support for Chinese study
https://ankiweb.net/shared/info/1752008591
GNU General Public License v3.0
26 stars 7 forks source link

DON'T MERGE: testing github actions #36

Closed kieranlblack closed 7 months ago

kieranlblack commented 7 months ago

@Gustaf-C The issue is actually really gnarly. The test suite patches the modules dict to try and avoid having any trace of aqt or anki slip through. I'm sure there was a good reason for doing this at the time but this seems like it could be reworked to be less foot-gunny and maybe only mock these things rather than patching them like this.

https://github.com/Gustaf-C/anki-chinese-support-3/blob/23093601cfdd39cbf08b09dc182f46abc89c2d6c/tests/__init__.py#L30-L43

Gustaf-C commented 7 months ago

Yeah that definitely feels like it can be done in a better way.