search

Gustash / react-native-giphy-keyboard

React Native implementation of the Giphy SDK for iOS and Android
12 stars 9 forks source link

Fix xcode 12 builds #9

Closed filipef101 closed 4 years ago

filipef101 commented 4 years ago

This upgrades to latest sdk and allows to build in latest xcode

filipef101 commented 4 years ago

@Gustash Can you review?

filipef101 commented 4 years ago

I think it makes sense to do a major version bump after this as afaik it will only work with XCode 12.1.X Right now it only works with XCode 11.4

filipef101 commented 4 years ago

Alternatively, you can drop the dependency on giphy. And then the users should add the necessary dependency they need for their xcode version. (note one of the commits is needed for giphy 2.x.x)

Gustash commented 4 years ago

Thanks @filipef101! Sorry, I only had time to get to this now. I'll do a major version bump, I think most users actively deploying to the App Store need to be on Xcode 12 now anyway, so no worries on breaking older versions 😊