search

Gustash / react-native-image-keyboard

React Native TextInput expansion to enable media input.
MIT License
147 stars 14 forks source link

Bump react peer dependency to support react v18.x #34

Closed MartianH closed 9 months ago

MartianH commented 1 year ago

Greetings, This line will trigger an ERESOLVE error due to the fact I am using React v18.x.

% npm i react-native-image-keyboard --save
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: parlay@0.0.1
npm ERR! Found: react@18.0.0
npm ERR! node_modules/react
npm ERR!   react@"18.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@">=16.8.1 <18.0.x" from react-native-image-keyboard@2.2.0
npm ERR! node_modules/react-native-image-keyboard
npm ERR!   react-native-image-keyboard@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I do not see why it wouldn't work under react v18.

Edit: just tried it out, it works just fine.

akashkola commented 9 months ago

@MartianH I'm running on react 18.2 and it's still giving me the same error, what can we do to make it compatible with 18.x?