search

GustavePate / lycheesync

a command line interface tool to sync lychee with any directory containing photos
108 stars 37 forks source link

Lycheesync is modifying source images when importing with the -l flag #70

Open benoitb85 opened 8 years ago

benoitb85 commented 8 years ago

Hi,

I was in the process of importing my whole photo library to lychee using lycheesync. I am about 20 hours of loading in (~30 000 photos) and I am discovering through my rsync backup script that a good amount of my source photos are modified: new timestamp, and it seems a bigger file size.

Looking at the photos, they are all vertical. Are you destructively rotating source JPG photos ?

My command line is: lycheesync.sync -l /data/photos /var/www/lychee /home/myname/lycheesync/ressources/conf.json

Is this by design ? I was not warned by reading the documentation that lycheesync would touch my source photos. I should have been careful and not run it with write access to the files.

joewashear007 commented 5 years ago

I think this would be because the original file is being saved over because of the symlink. the photo.destfullpath points to the symlink, which then points to the original. I found this by using docker volumes, I kept getting a bunch of read-only exceptions because my source is mounted as a read-only volume.

https://github.com/GustavePate/lycheesync/blob/043bc70d6f56ac791075bdc033b70d66f26ec60f/lycheesync/lycheesyncer.py#L251