names with '&' will break calculations from hyperlink

GustavoFernandes / order-splitter

https://gustavofernandes.github.io/order-splitter/

MIT License

3 stars 3 forks source link

names with '&' will break calculations from hyperlink #36

Closed ghost closed 7 years ago

ghost commented 7 years ago

example:

1   12 Nuggets -    $4.39
    Sauce: Ketchup
    Label for:Alice

2   Tots -  $1.99
    Label for:Bob

1   6 Wings -   $6.29
    Wing Seasoning: Sweet Honey BBQ
    Label for: Harneys & sons,

https://gustavofernandes.github.io/order-splitter/index.html?tax=0&fee=0&tip=20&Alice=4.39&Bob=1.99&%20Harneys%20&%20sons,=6.29

you can click on it, but it'll break the calculations for Harneys & sons

GustavoFernandes commented 7 years ago

Fixed by #38

GustavoFernandes commented 7 years ago

The name Hirsh H#ir&sh%@! doesn't encode properly for the hyperlink

ghost commented 7 years ago

beat me to reopening it

GustavoFernandes commented 7 years ago

Fixed in v0.5.1