Gusto / apollo-federation-ruby

A Ruby implementation of Apollo Federation
MIT License
216 stars 76 forks source link

feat: introduce optional `resolve_references` method #206

Closed col closed 2 years ago

col commented 2 years ago

This addresses the issues with using data loader in the existing resolve_reference method. (See: #205) By grouping all the references of the same type into a single call to resolve_references the records can more easily be loaded as a batch. This can be done using a data loader (.load_all) or just a direct DB query as all the references are provided in a single method call.

The existing resolve_reference method is still supported but resolve_references will be the preferred approach.

geshwho commented 2 years ago

@col Thank you for the PR! This is looking pretty good to me.

rylanc commented 2 years ago

:tada: This PR is included in version 3.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: