fix: Warden no longer available in latest graphql gem versions

Gusto / apollo-federation-ruby

A Ruby implementation of Apollo Federation

MIT License

216 stars 76 forks source link

fix: Warden no longer available in latest graphql gem versions #278

Open camero2734 opened 2 months ago

camero2734 commented 2 months ago

Fixes #276

As explained in the issue, in the latest versions of graphql, the warden object is no longer available in most places.

It's mostly replaced by @types -- which I initially used in the first pass -- but since the warden object can still be constructed, doing so was the easiest route for backwards compatibility purposes.

comatory commented 2 months ago

🙏 We're running into issues with graphql not being compatible. Would really appreciate fixing this. 🙇

arinhouck commented 2 months ago

This is blocking our upgrade of graphql-ruby as well. 🙇 Would be very grateful for a resolution on this one soon, anything else needed to get this moving forward?

vaclavbohac commented 2 months ago

I've made an experiment where I forked this repo and made it run with the latest graphql-ruby package. I discovered there are many other problems par this one. If we are able to fix them, we can open a PR upstream.

https://github.com/productboardlabs/apollo-federation-ruby/pull/1

Here's an example of the test run https://app.circleci.com/pipelines/github/productboardlabs/apollo-federation-ruby/4/workflows/b750a570-c50b-41f6-b658-10c91871e1bc/jobs/88

Bajena commented 1 month ago

FYI: It seems that I managed to fix it "properly" in https://github.com/Gusto/apollo-federation-ruby/pull/282/files#diff-713da7628fd274d64409afdd877545f73256f9e15b7e120abc8dfcf8dbe8bfc7.