Gusto / it-cpe-opensource

Tools used by the CPE team at Gusto to manage our endpoints and software deployment systems.
Other
59 stars 29 forks source link

Channels #26

Closed w0de closed 4 years ago

w0de commented 4 years ago

First pass at implementing "channels" to allow variation in promotion schedule. Looking for feedback @ChefAustin - a solution to #25

ChefAustin commented 4 years ago

Looping in @erikng for his thoughts, too.

erikng commented 4 years ago

The main function returns an int and a float. Perhaps you should round the float to an integer so the type is static?

w0de commented 4 years ago

The main function returns an int and a float. Perhaps you should round the float to an integer so the type is static?

The function always returns a float. It is important that is is a float, since this implementation expects <1.0 for faster channels. (The promotion period is a function of the channel multiplier, a multiplier of 0.5 will result in a half-length promotion period.)

erikng commented 4 years ago

The function has a return 1

w0de commented 4 years ago

The function has a return 1

Haha, good point. I'll make that a float.