search

Gusto / react-masked-field

A masked input component built in React
MIT License
19 stars 7 forks source link

Fixes infinite loop bug #33

Closed inoda closed 4 years ago

inoda commented 4 years ago

If you start typing from index 1 to the end of the mask, and then go back to type at index 0, an infinite loop occurs and the browser crashes. This happens in other scenarios too (e.g. last 3 chars, then enter the 4th to last char).

I haven't been able to manually test this locally by importing the local module into a project and hooking it up - I'm just going off of tests here.

Update: I did manually test this as well

inoda commented 4 years ago

@hectorvirgen Will bump the ZP side in a PR today!

rylanc commented 4 years ago

:tada: This PR is included in version 2.1.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rylanc commented 4 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: