Configuration max_instances was being ignored - fix

Gutza / octave-daemon

The PHP network daemon for GNU Octave

http://projects.moongate.ro/octave-daemon/

GNU Affero General Public License v3.0

16 stars 2 forks source link

Configuration max_instances was being ignored - fix #3

Closed tasinet closed 11 years ago

tasinet commented 11 years ago

The Global Configuration "max_instances" was ignored when launching children processes - octave-daemon would always launch 3. Fix for that.

tasinet commented 11 years ago

The proposed fix also changes main daemon run() loop to usleep(1000) instead of 100 (0.1ms -> 1ms), as this was causing high CPU utilization even when idle

Gutza commented 11 years ago

Hey there,

Sorry for the late reply -- I was quite caught up with my own stuff, and I wanted to merge ASAP, so I just did that without any notice. Anyway, better late than never: thanks for the patch! The bug fix is certainly welcome. The loop delay thing, I don't know -- I included it because you noticed about it, but I personally didn't see any significant load, although I have a server running that code day in and day out.

Anyway, thanks again and keep 'em coming! :-)

Cheers, Bogdan