Guy-L / parakit

Scripting framework to extract and analyze Touhou game data for score players and anyone looking for insight!
7 stars 2 forks source link

Referencing current Offset object directly to get offsets #22

Closed Guy-L closed 4 months ago

Guy-L commented 10 months ago

Using properties of the current games' offset object directly instead of using it to define hundreds of variables in interface.py would drastically improve readability. The only reason this hasn't been done is due to performance concerns, so performance should be evaluated before and after this change.

Guy-L commented 4 months ago

actually the main reason we're gonna keep it this way is readability and not bloating the namespace with the Offset object. bloating it with variables is no more a burden than not doing that and makes for more readable code. plus python has a decent way of doing this. see 6a08fb4abdd9f64766cb96077c46b912b214502e