GuyKh / ims-custom-component

The Israel Meteorological Service (IMS) integration component for home assistant
MIT License
44 stars 8 forks source link

The caption in Weather is not accurate #24

Closed meni123 closed 1 year ago

meni123 commented 1 year ago

Whenever the weather is clear without clouds or rain, an icon of a moon appears and a caption of a clear night, even if it is during the day, What should be an icon of a sun and an inscription of a bright day, This is how it looks in other integrations

GuyKh commented 1 year ago

The reason is the mapping the IMS provide. https://ims.gov.il/en/weather_codes

checkout "1250":

"1250": {
"id": "1",
"desc_en": "Clear",
"weather_code": "1250",
"ims_order": "1",
"night": "1",
"display": "1",
"desc": "Clear"
},

As far as I understood it - the mapping between code 1250 to clear-night (as described here) is valid - becuase it's "night": 1 and "desc_en": "Clear" But - it seems that this is returning during daytime too

GuyKh commented 1 year ago

This will be fixed in next release

GuyKh commented 1 year ago

@meni123 - please check with 0.1.4

GuyKh commented 1 year ago

Closing due to inactivity