search

Guyutongxue / clangd-in-browser

Port clangd language server to WASM, and run it in your browser.
https://clangd.guyutongxue.site/
MIT License
26 stars 5 forks source link

Update to monaco-languageclient 8.4.0 and monaco-editor-wrapper 5.1.1 #3

Closed kaisalmen closed 1 month ago

kaisalmen commented 1 month ago

In addition to update monaco-languageclient@8.4.0 this also introduces monaco-editor-wrapper@5.1.1:

The wrapper takes a UserConfig that configures the language client and monaco-editor and all required monaco-vscode-api related services. I switch to vscode textmate cpp highlighting and thereby removes the need for the extra theme definitions. Also the language client configuration moved into one function that is now included in editor.ts. monaco-editor-wrapper internally uses LanguageClientWrapper that configures , starts and disposes the languageclient. By using it for the need for more boiler-plate code is removed.

kaisalmen commented 1 month ago

@Guyutongxue the vite build is broken. Using the dev server was no problem. I can reproduce this locally when using:

npx statikk --port 8000 --coi

in the dist folder. I need to find out why

Guyutongxue commented 1 month ago

Oops.

PR has been reverted and you can recreate one PR once fixing is done.

Btw I should use Vercel to preview PR but I do not have time for now lol

kaisalmen commented 1 month ago

@Guyutongxue sorry for the inconvenience. I didn't realize you deploy immediately. I will understand what is wrong. vite preview shows the same effect. I will open another PR once this is resolved. Did you test this locally already in dev mode?

Guyutongxue commented 1 month ago

No, I don't have my 'PC for developing' with me now so, emm I'm just pressing "merge" button on my mobile 🤣

next time I'll test locally first sry