search

GuzziMP / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Custom Movie Group Settings are not applied in GUI and Layout is not saved. #284

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Go to a 'Group' list of grouped films
2. Change the Layout and Sort Options
3. Select 'Save current custom view settings' from context menu

What is the expected output? What do you see instead?
Settings for both sort and layout are not 'saved' until you exit MP.  Thus if 
you exit MF (or change DB) and return they are not applied.

Even after exiting MP only Sort Settings for Movie Groups work correctly - i.e. 
display the change in MF Setup and when you reload MP/MF.

Checking MyFilms.xml config - LayOutInHierarchies is changed in MyFilms.xml but 
does not alter the Movie Group Layout settings in MF Setup and is not applied 
when you reopen MP/MF like sort settings are. So not sure why.

Please use labels and text to provide additional information.
IMO Changing custom view settings should override the view 'states'

Original issue reported on code.google.com by Dade...@gmail.com on 20 Nov 2012 at 2:54

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 20 Nov 2012 at 10:50

GoogleCodeExporter commented 8 years ago 
Ok, as far as I understand the issue, the bnehaviour is "expected".
You might remember, that in the initial implementation of new "Views" system, I 
had included the films and group settings as part of the (userdefined) view.
Later, we removed that for "simplicity reasons".
Thus, now those settings are "global settings" - and as such, they are NOT 
saved, when you save the settings of a view (which is the menu option you 
mention).
A solution could be, that in such a context, the global settings will be 
altered - but that would of course apply to all views - and it is a bit 
confusing for the user, as he/she might think, the saving is only for the 
current view context.
Other solution could be to add a new context menu option in such group views 
with something like "save view settings for group views" - that makes it more 
clear, it is a global setting and not related to the view. It is however a new 
feature, as we currently afaik do NOT have any option to alter those settings 
in GUI (as you experienced in your tests).
Generally, we probably should NOT display the "save custom view settings" in a 
movie context - as it makes the user think, he/she could save the group 
settings by that command.
Comments please.

Original comment by Guzz...@googlemail.com on 20 Nov 2012 at 11:12

GoogleCodeExporter commented 8 years ago 
After checking code:
The settings for Layout, sort order and sort field are saved when MF exits - so 
no need for manual save context option.
Option dialogs for views (save, add) will be removed to solve this issue - 
adding and/or saving collections to menu is currently not supported.

Original comment by Guzz...@googlemail.com on 20 Nov 2012 at 12:12

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r2750.

Original comment by Mikeplan...@web.de on 20 Nov 2012 at 12:16

GoogleCodeExporter commented 8 years ago 
Verified 'Save current custom view setting" no longer displays.
Also using the new 'Save Current Layout and Sort' options solves the issue of 
when they are saved.
(see Issue #285: navigation engine does have inconsistant behaviour for start 
settings)

Original comment by Dade...@gmail.com on 29 Nov 2012 at 3:06