search

GuzziMP / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Different movies with the same title are not handled correctly #303

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Download "The Italian Job", the 2003 and the 1969 version
2. import with AMC updater
3. look at the thumbs / fanart, they will be wrong for at least one Movie

The root cause of this is a Poor model for linking movies to their dependent 
graphics files.

There are 4 graphical items which each movie file depends on:

1. The 'Large' thumb (600x800 +) displayed when the movie is selected
2. The fanart images
3. The 'Med' thumb  (400x600) displayed in the "Big icon" layout
4. The 'small' thumb (100x150) displayed in the 'Big icon list" layout

MyFilms currently relates a Movie file to these graphics using information from 
the catalog .xml file

1. (The 'Large' thumb) is explicitly defined using Picture=
2. (The fanart) is derived from the OriginalTitle=
3. (The med Thumb) is derived from the OriginalTitle=
4. (the small Thumb) is derived from the OriginalTitle=

Sorry, but this needs improving. It falls flat on it's face when two Movies 
have the exact same OriginalTitle.
Each Movie file already has a unique identifier in the catalog .xml file: the 
IMDB number, that should be used to unambiguously identify the dependent 
artwork.

In my setup I have sofar identified 12 movie pairs which are displayed 
incorrectly because of this.
I have not only manually downloaded the correct Thumbs and fanart, Since I want 
a repeatable process, I had to write an extensive shell script, which edits the 
catalog .xml file, and updates the Picture= and the OriginalTitle= fields based 
on the IMDB hook I wrote into the thumbnail's file name.

Please please fix this.

Original issue reported on code.google.com by martin.h...@gmail.com on 1 Jan 2013 at 5:22

Attachments:

GoogleCodeExporter commented 8 years ago 
moved to 6.1, as the required changes would break compatibility for existing 
installs, which we do not want for a maintenance release

Original comment by Guzz...@googlemail.com on 26 Jan 2013 at 10:56

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 12 Aug 2013 at 9:12

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 6 Apr 2014 at 12:50

GoogleCodeExporter commented 8 years ago 
An alternative to the IMDB number as key, also could be the Movie number in the 
database.

Harald63

Original comment by per.thor...@gmail.com on 29 May 2014 at 1:14