search

GuzziMP / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Remove 'Use MP Logos' option #344

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What area does your enhancement or feature relate to? (i.e. Config/Setup,
GUI, options, Skin, AMC Updater, Grabber Interface, etc.)
Setup - Logos tab and Installer.
What is the purpose or benefit of the new feature or enhancement?
Default skin no longer provides many logos and the style and size keep 
changing. MyFilms already provides a full set of logos to work with the plugin 
in C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\MyFilms\DefaultLogos
How would you expect it to work? (Accessed via, new settings required, Skin
changes/new properties)
Same as now. However, if skins provide logos, and wish to use them by default, 
they simply store MyFilmsLogos.xml in their skin folder with it preset to 'Use 
logos of currently selected skin.

The following changes are required:
1. Preset Logos to "Use MyFilms Logos Pack"
2. Remove the option "Use MP Logos"
3. Remove the following folders from SVN and Installer:
   1. \Installer\Skin.13\DefaultWide\Media\Logos\MyFilms
   2. \Installer\Skin.13\Default\Media\Logos\MyFilms
   3. \Installer\Skin.12\DefaultWide\Media\Logos\MyFilms
   4. \Installer\Skin.12\Default\Media\Logos\MyFilms
   5. \Installer\Skin\Blue3wide\Media\Logos\MyFilms
   6. \Installer\Skin\Blue3\Media\Logos\MyFilms

I am not sure if \Installer\Thumbs\MyFilms\DefaultLogos.MP13 is needed. I don't 
think it is installed (Installer\Thumbs\MyFilms\DefaultLogos) and it makes it 
confusing where to commit updated to logo images.

Skin Changes Docs are required to inform skinners how to use their own logos.

Original issue reported on code.google.com by Dade...@gmail.com on 29 Jul 2013 at 6:03

GoogleCodeExporter commented 8 years ago 
On further reflection I changed my request ;)
I don't think we should change the preset - rather leave it as 'use logos of 
currently selected skin' as that preserves backwards compatibility. 

The ONLY case where we may wish to change to MyFilms logos pack is for Default 
skin - if so then we should install MyFilmsLogos.xml to Default skin folder, 
rather than have every skin add it if they wish to use skin logos.

Original comment by Dade...@gmail.com on 1 Aug 2013 at 2:47

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 7 Aug 2013 at 10:04

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r2895.

Original comment by Guzz...@googlemail.com on 8 Aug 2013 at 2:30

GoogleCodeExporter commented 8 years ago 
I can verify that the skin logo files are removed from SVN and installer 
(though MyFilms-12.xmp2 still contains references in the skin files section to 
Blue3/wide logos (e.g. %Skin%\Blue3\Media\Logos\MyFilms\Family.png) which could 
be removed now. 

However, the main problem is the installer does NOT remove the previous 
Default/Wide \Media\Logos\MyFilms folder, so if you had installed MyFilms 
previously, the logos still exist :(.  Thus I have reopened this issue since 
installer should also delete any previous folders if they exist i.e.:
     Default\Media\Logos\MyFilms
     Defaultwide\Media\Logos\MyFilms

Logos Setup wiki page has been updated - removing references to MP Logos Pack

Original comment by Dade...@gmail.com on 28 Aug 2013 at 4:11

GoogleCodeExporter commented 8 years ago 
OK I am a bit confused now. Although I don't see the 
Default[wide]\Media\Logos\MyFilms in the installer, if I delete the folders 
manually, they are actually reinstalled using build 2908!

Original comment by Dade...@gmail.com on 30 Aug 2013 at 3:56

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r2920.

Original comment by Guzz...@googlemail.com on 31 Aug 2013 at 1:49

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r2921.

Original comment by Guzz...@googlemail.com on 1 Sep 2013 at 12:29

GoogleCodeExporter commented 8 years ago 
verified that r2921 removes the Default skin media\logos\MyFilms folders on 
install.

Original comment by Dade...@gmail.com on 1 Sep 2013 at 1:17