search

GuzziMP / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Trakt (test internal menu) in test mode, does not work #358

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Go to Details Window
2. Open Context Menu
3. Select 'Trakt (test internal menu)

What is the expected output? What do you see instead?
MyFilms just redisplays the context menu rather than opening theiInternal Trakt 
Menu

Please use labels and text to provide additional information.
Skins can implement the Trakt Context menu via a button with ID 97270.

Original issue reported on code.google.com by Dade...@gmail.com on 28 Sep 2013 at 4:06

GoogleCodeExporter commented 8 years ago 
Code was added long ago, when required Trakt version was not yet published, so 
it has to be enabled now. Also relates to adding person info to trakt objects

Original comment by Mikeplan...@web.de on 29 Sep 2013 at 8:27

GoogleCodeExporter commented 8 years ago 
Also added extension to support people searches recently introduced in trakt.

Original comment by Mikeplan...@web.de on 29 Sep 2013 at 7:49

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r2931.

Original comment by Guzz...@googlemail.com on 29 Sep 2013 at 7:55

GoogleCodeExporter commented 8 years ago 
using r2934 the internal Trakt Menu works now (and has more options than the 
button skins can add! The only incorrect item is 'User Profile' (new option in 
Trakt) which opens 'Lists'. And there is no item for 'Network' (which used to 
be Friends)

Original comment by Dade...@gmail.com on 3 Oct 2013 at 2:24

GoogleCodeExporter commented 8 years ago 
The issues with Trakt internal menu need to be reported to Trakt, as we do not 
have any influence on what is included and what isn't...

Original comment by Mikeplan...@web.de on 5 Oct 2013 at 8:13

GoogleCodeExporter commented 8 years ago 
I added 'Network' to the ContextMenu API. I can't reproduce your problem with 
'UserProfile' loading 'Lists'.

Are you sure your skin IDs are correct?

Original comment by damien.haynes@gmail.com on 5 Oct 2013 at 8:56

GoogleCodeExporter commented 8 years ago 
Guzzi, it still looks like your building up the menu yourself unless the code 
is just left over?

Original comment by damien.haynes@gmail.com on 5 Oct 2013 at 9:01

GoogleCodeExporter commented 8 years ago 
Guzzi, the 'ShowSearchByMenu' method signature has changed now in upcoming 
release. This would not be a problem for you if you call 
'ShowTraktExtMovieMenu'.

Original comment by damien.haynes@gmail.com on 5 Oct 2013 at 9:03

GoogleCodeExporter commented 8 years ago 
I looked at the diff a bit closer and noticed your using the 
'ShowTraktExtMovieMenu' :) but you also use the custom one you build up.

I recommend removing that unless you really need it for something, I can help 
fill any gaps on the trakt end if you feel something important is missing. I 
will always will try to make 'ShowTraktExtMovieMenu' compatible by adding 
overloads but I dont want to do that for everything.

Original comment by damien.haynes@gmail.com on 5 Oct 2013 at 10:44

GoogleCodeExporter commented 8 years ago 
"#5 Mikeplanet5@web.de 
The issues with Trakt internal menu need to be reported to Trakt, as we do not 
have any influence on what is included and what isn't..."
Yep, but since we started here now, maybe best to keep it in one place?

"#6 damien.haynes 
I added 'Network' to the ContextMenu API. I can't reproduce your problem with 
'UserProfile' loading 'Lists'.

Are you sure your skin IDs are correct?"
Using DefaultWide skin XMLs provided with Trakt.  In Trakt 3.1.1.0 User Profile 
works correctly, but new Network button opens my Lists in Trakt :(

MF log only reports "TraktInternalMenu(): Call with Title".  Trakt log attached 
- though I can't find where it is grabbing the ID for Lists

Original comment by Dade...@gmail.com on 6 Oct 2013 at 4:01

Attachments:

GoogleCodeExporter commented 8 years ago 
I can't understand how it could open Lists when clicking on Network. What 
happens when you use the context menu from the TVSeries F9 menu -> Trakt?

In trakt code all we do is call the network gui:
https://github.com/Technicolour/Trakt-for-Mediaportal/blob/master/TraktPlugin/GU
I/GUICommon.cs#L2070

Note: I have only tested from TVSeries.

Original comment by damien.haynes@gmail.com on 6 Oct 2013 at 5:35

GoogleCodeExporter commented 8 years ago 
Dadeo, I noticed an issue in code further up which explains your symptoms :)

Will be fixed in 3.1.2 or 3.2.0.

Original comment by damien.haynes@gmail.com on 6 Oct 2013 at 5:55

GoogleCodeExporter commented 8 years ago 
Yep works fine from TV Series - glad you found the issue running from MyFilms!

Original comment by Dade...@gmail.com on 6 Oct 2013 at 7:08

GoogleCodeExporter commented 8 years ago 
Add Producers to TraktMenu

Original comment by Guzz...@googlemail.com on 5 Apr 2014 at 6:54

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r2968.

Original comment by Guzz...@googlemail.com on 5 Apr 2014 at 6:55

GoogleCodeExporter commented 8 years ago 
I can verify all works well now, BUT we need to move it from TestMode to 
NormalMode and remove MF Trakt Menu.

Related to Issue #359 - Trakt Friends no longer works

Original comment by Dade...@gmail.com on 20 Jun 2014 at 1:36

GoogleCodeExporter commented 8 years ago 
ok, will do and commit to this issue

Original comment by Guzz...@googlemail.com on 22 Jun 2014 at 1:15

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r3039.

Original comment by Guzz...@googlemail.com on 22 Jun 2014 at 1:23

GoogleCodeExporter commented 8 years ago 
Verified, already moved from Test mode in 3039 so removed the TestMode label

Docs Updated: 
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/17_Extensions/3_Plugins/My_Film
s/3_Using_My_Films/Trakt

Original comment by Dade...@gmail.com on 22 Jun 2014 at 3:11