search

GuzziMP / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Update MF skininterfaceversion to 1.1 due to V6.2 changes #387

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Update MF skininterfaceversion to 1.1 due to V6.2 changes

Original issue reported on code.google.com by Guzz...@googlemail.com on 22 Jun 2014 at 2:15

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r3042.

Original comment by Guzz...@googlemail.com on 22 Jun 2014 at 2:16

GoogleCodeExporter commented 8 years ago 
Verified, changed to 6.1.0 as the skin changes are for 6.1.0 not 6.2.0

Technically Major version # is supposed to be for 'required' changes and minor 
version # for optional changes, but since this is the first bump, and the only 
required change is for MyFilmsDialogImageSelect for downloading Collection 
covers which not all users need/use, I think the minor version bump is good.

Docs updated: 
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/17_Extensions/3_Plugins/My_Film
s/Skinning_My_Films/Skin_Changes

Original comment by Dade...@gmail.com on 22 Jun 2014 at 7:13

GoogleCodeExporter commented 8 years ago

Original comment by Dade...@gmail.com on 22 Jun 2014 at 7:14

GoogleCodeExporter commented 8 years ago 
I think we should revert this change for 6.1.0. We should have done it in 
testmode when we first introduced the changes.

So I changed title and milestone back to 6.2.0. My bad!

Original comment by Dade...@gmail.com on 30 Jun 2014 at 8:22

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r3106.

Original comment by Guzz...@googlemail.com on 30 Jun 2014 at 8:49

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 30 Jun 2014 at 9:26