search

GuzziMP / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Mapped fields: add to start /end in different lines #401

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
I´m not sure if this is a issue report or a feature request, because I don´t 
know if this is supposed to work by this way.
When you map fields in the grabber configuration, and add them to the 
start/end, they will be placed in different lines. Shouldn´t they be added in 
the same line of the original field?

Original issue reported on code.google.com by vivamiloro on 9 Jul 2014 at 6:43

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago

Original comment by vivamiloro on 9 Jul 2014 at 6:48

GoogleCodeExporter commented 8 years ago

Original comment by vivamiloro on 9 Jul 2014 at 6:50

GoogleCodeExporter commented 8 years ago

Original comment by vivamiloro on 9 Jul 2014 at 6:54

GoogleCodeExporter commented 8 years ago 
IIRC 'Add to Start'is intended to add to a new line - because many fields are 
long text strings and  in most cases you would want a new line, e.g. adding 
tagline to start of Description which I think was the original use case when we 
didn't have a separate tagline field (as in AMC3) 

Perhaps it would be better to explain the use case for the feature - what you 
are trying to accomplish rather than how you want to do it? 

In the sample above - adding Ratings to Country field - how would you know what 
country the rating links to? Grabber Engine does support 'Rate 2' parameter 
(rarely used) but may still not meet your needs.

Original comment by Dade...@gmail.com on 9 Jul 2014 at 8:05

GoogleCodeExporter commented 8 years ago 
The sample above is just a test I did to post here.
The use I was thinking about is adding the words "Top 250" to the category 
field, as a new category. If a film is one of the top 250, I extract that info 
using a generic field and the I add that as category

Original comment by vivamiloro on 9 Jul 2014 at 7:19

GoogleCodeExporter commented 8 years ago 
Indeed, the "new line" is intended. We could remove it, as users could add the 
line feed to either the original or the added field in teh grabber definitions 
- that way it would be more flexible. Would require modifications of the 
existing grabber scripts and this modification wouldn't be compatible with 
older MF versions.
What do you think?

Original comment by Guzz...@googlemail.com on 10 Jul 2014 at 12:40

GoogleCodeExporter commented 8 years ago 
We need a decision - am am fine with either solution.

Original comment by Guzz...@googlemail.com on 30 Jul 2014 at 6:54

GoogleCodeExporter commented 8 years ago 
I'm really hesitant because it would change how fields are added for existing 
users: e.g. AMC3 catalog types (not sure how many are still using AMC3) or any 
user who has used the parameter previously. 

Perhaps if Issue #399 ends up meeting z3us' need and you don't need to add 'Top 
250' to category?

Original comment by Dade...@gmail.com on 31 Jul 2014 at 3:47