GwenNelson / distcc

Automatically exported from code.google.com/p/distcc
GNU General Public License v2.0
0 stars 0 forks source link

CPlusPlus test case fails with GCC 4.4.1 #60

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
distcc version is svn rev 712

$ gcc --version
gcc (Ubuntu 4.4.1-4ubuntu9) 4.4.1

$ uname -a
Linux cesar-laptop 2.6.31-19-generic #56-Ubuntu SMP Thu Jan 28 02:39:34 UTC
2010 x86_64 GNU/Linux

I'm trying to run tests in non-pumped mode and get CPlusPlus test fail:
$ make distcc-maintainer-check

... SKIP ...
CPlusPlus_Case                 FAIL
-----------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cesar/workspace/c/distcc.git/test/comfychair.py", line 355,
in runtest

... SKIP ...

stderr:
testtmp.cpp:2:2: warning: #import is a deprecated GCC extension
testtmp.cpp:3:2: warning: #import is a deprecated GCC extension

-----------------------------------------------------------------

It seems to me that the test case uses deprecated compiler directive
#import instead of #include. I don't know since when was that GCC warning
introduced but I substituted #include instead of it (see
CPlusPlus_Case.patch) and tests passed like a charm.

I don't know whether you put that #import there intentionally to test how
distcc handles obsolete. If so, consider CPlusPlus_Case_no_warn.patch
disabling that warning for that particular test case.

Original issue reported on code.google.com by madkinder on 18 Feb 2010 at 10:10

Attachments:

GoogleCodeExporter commented 9 years ago
The use of #import in the C++ test case is a cut-and-paste error...
#import should only be used in the Objective-C and Objective-C++ test cases.
So CPlusPlus_Case.patch is the right patch.
I will apply it.

Original comment by fergus.h...@gmail.com on 18 Feb 2010 at 11:36

GoogleCodeExporter commented 9 years ago
Fixed in SVN revision 714.

Original comment by fergus.h...@gmail.com on 18 Feb 2010 at 11:40