search

GwentAPI / gwentapi

The code for GwentAPI
https://gwentapi.com
BSD 3-Clause "New" or "Revised" License
47 stars 1 forks source link

New patch is out with lots of cards change #34

Closed zhouzi closed 7 years ago

zhouzi commented 7 years ago

Hooray, the new patch is out 🎉

Lots of cards have changed and there are some new ones too.

Soreine commented 7 years ago

Hello @Tri125 I think the implicit question here is when will the cards will be updated and what should we do to help you with that. We are excited to have our Chrome extension cover the new patch, hence the casual tone of @Zhouzi :)

zhouzi commented 7 years ago

The API seems to be up to date but the cards' images are missing (throwing a 404). Reading https://github.com/GwentAPI/gwentapi/issues/23#issuecomment-314112361, I feel like the amount of work required to maintain the API is pretty high. I hope we can help!

Is the data still pulled from crawling gwentify through arachas? I am looking at the code right now and can give a hand to maintain it.

Tri125 commented 7 years ago

Sorry, I should have commented before closing the issue, that was pretty rude.

Please check GwentAPI twitter account for public announcement.

Artworks are never going to be on the same day as a data update. I have to patiently wait for a busy CD RED employee to send me the updated artworks OR wait for other generous community devs to upload the new artworks after a busy CD RED employee sent them the artworks. When I finally get hold on them it might or might not be when I'm also available to work on the API.

Tri125 commented 7 years ago

Also, you can keep an eye on /u/gwentAPI for bigger announcement.

Artworks have now been updated. :+1:

zhouzi commented 7 years ago

Thanks @Tri125 💪 I'll make sure to follow the Twitter and Reddit account. I went through the READMEs but I'm unsure about the overall process you have to go through to update the API. From my understanding, it looks like:

  1. Crawl gwentify with arachas for cards data
  2. Upload the images (sent by a CD RED employee)
  3. Feed the mongo database
  4. Deploy

Am I right? Arachas' README says it's deprecated so if not crawling gwentify, how are you getting the data?

Tri125 commented 7 years ago

Well, this one isn't outdated :P https://github.com/GwentAPI/gwentapi/blob/master/DATABASE_INSTRUCTIONS.md Not distributing json for legal reason.

zhouzi commented 7 years ago

Hehe thanks! Actually, it says:

Obtain a copy of the card data in json

How do you obtain it? Is the program outputting it?

Tri125 commented 7 years ago

Ping me up on reddit. This won't be discussed here.