UpdateChecker fails to handle cases where an invalid response is returned

Gwindow / WhatAndroid

The What.CD Android App

http://gwindow.github.com/WhatAndroid/

BSD 2-Clause "Simplified" License

100 stars 20 forks source link

UpdateChecker fails to handle cases where an invalid response is returned #23

Closed Twinklebear closed 11 years ago

Twinklebear commented 11 years ago

It seems the Github api is having some issues and returning

{
  "message": "Not Found"
}

instead of the release api information that we expect, and since this is an uncaught error it's causing the app to crash. The fix should be pretty simple, just catch the error thrown at UpdateChecker.java line 80 and report no updates found, I'll look into it tonight.

Twinklebear commented 11 years ago

This is solved in the hotfix branch robuster-updater, merged into master: 7124f12edee41ed57edce88544cc9ce043ab16af and develop: d1f2ba9b2bc84536c2227a4ff1a6f308774b58d8 and will be pushed out as 1.3.1. This does leave me a bit worried about the releases api though, since it doesn't seem to be documented anywhere and has started giving back 404/not found messages, I'm a bit worried about it coming back. I guess we'll wait and see.