search

Gwindow / WhatAndroid

The What.CD Android App
http://gwindow.github.com/WhatAndroid/
BSD 2-Clause "Simplified" License
100 stars 20 forks source link

Drawable crash fix #51

Closed stuxo closed 8 years ago

stuxo commented 8 years ago

Please review commit fec29b9 to see if this would fix the other issue, with the theme having to be explicitly set.

stuxo commented 8 years ago

I have tested this on android 4.4.2 (galaxy s4) and it works fine. Lets try get this to the people asap.

Twinklebear commented 8 years ago

Awesome, could we also remove the hack in https://github.com/Gwindow/WhatAndroid/commit/65dd2e6f6776f45f00cf9e212b5bf45e8221b622 ? It looks like we set a default theme in WhatApplication now, so would things work as expected with themes being set?

stuxo commented 8 years ago

Yes, this should be able to be removed. Shall we quote a few people in the thread and ask them to verify this issue has been fixed before pushing the release out?

Twinklebear commented 8 years ago

Yea let's remove that hack then ping them about testing the debug build. It'd probably be best to see that the issues are actually fixed before we push out another release :P

stuxo commented 8 years ago

Reverted, should be ready to build now.

Twinklebear commented 8 years ago

Cool, I'll merge this in develop then ping folks on the forums