GwtMaterialDesign / gwt-material-addins

Custom Components for gwt-material.
https://gwtmaterialdesign.github.io/gmd-addins-demo/
Apache License 2.0
35 stars 46 forks source link

TimePicker now defaults in hour24 mode to value as in am mode. #399

Open vokke opened 4 years ago

vokke commented 4 years ago

There was a problem with timepicker in hour24 mode: It always did default to now() - isValidTime failed in timepicker.js This is now solved.

And you can setStartTime(date) or setStartTime(string) as start time if value isn't set.

kevzlou7979 commented 4 years ago

Ok I think this is a good feature. Could we not just refactor the current code format - as we used standard format to all widgets. If you can change that then we can merge this request.

vokke commented 4 years ago

Thanks for the positive feedback. However, I'm not sure how to help to refactor the code. Can you give me a hint for this? I'd really like to contribute to this great project. Thanks