IComponentDataFields and all its subclasses seemse to be custom Java classes to be exported to Javascript, therefore should have no parameters in JsType annotation.

GwtMaterialDesign / gwt-material-amcharts4

Amcharts Version 4 for GMD

https://gwtmaterialdesign.github.io/gmd-amcharts4-demo/

Apache License 2.0

3 stars 4 forks source link

IComponentDataFields and all its subclasses seemse to be custom Java classes to be exported to Javascript, therefore should have no parameters in JsType annotation. #2

Open yechenqiao opened 5 years ago

yechenqiao commented 5 years ago

Please take this with a grain of salt as I'm on a newer code base Amcharts 4.4.x, while this code base is currently on 4.0.x.

I've noticed the classes extending IComponentDataFields has the wrong class annotations. These causes these classes to not be able to be used in Java at all via constructor.

Instead of @JsType(isNative = true, ...) the annotation should have just been @JsType because the class is not defined in Javascript and we are exporting the class from Java.