search

GwtMaterialDesign / gwt-material-amcharts4

Amcharts Version 4 for GMD
https://gwtmaterialdesign.github.io/gmd-amcharts4-demo/
Apache License 2.0
3 stars 4 forks source link

Library upgraded to AmCharts Version 4.8.4 (January 25, 2020). #9

Closed andreaht closed 4 years ago

andreaht commented 4 years ago

Added more languages, more themes, exposed new properties, added deps to export chart data as xlsx or pdf, added plugins javascritpts.

kevzlou7979 commented 4 years ago

Ok will be reviewing this on weekends.

On Tue, Jan 28, 2020 at 4:10 PM andreaht notifications@github.com wrote:

Added more languages, more themes, exposed new properties, added deps to export chart data as xlsx or pdf, added plugins javascritpts.

You can view, comment on, or merge this pull request online at:

https://github.com/GwtMaterialDesign/gwt-material-amcharts4/pull/9 Commit Summary

  • Library upgraded to AmCharts Version 4.8.4 (January 25, 2020).

File Changes

Patch Links:

- https://github.com/GwtMaterialDesign/gwt-material-amcharts4/pull/9.patch

https://github.com/GwtMaterialDesign/gwt-material-amcharts4/pull/9.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material-amcharts4/pull/9?email_source=notifications&email_token=AAX6EF7BFVNFATQVMBFU6FDQ77R7LA5CNFSM4KMODJT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJETJ5A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EF26HRCIRNZR3L66BN3Q77R7LANCNFSM4KMODJTQ .

kevzlou7979 commented 4 years ago

I think I need to finalize https://github.com/GwtMaterialDesign/gwt-material-amcharts4/pull/8 this PR before merging this. Is this PR merged based on the release_2.1 to avoid conflicts in the future?

andreaht commented 4 years ago

I don't think you will have conflicts, because I've updates and added the javascripts, removed old ones. I've also added some properties in the java sources for accessing some of the new features if the library.

kevzlou7979 commented 4 years ago

Thanks for the PR - we will be finalizing the demo showcase too for the new features.