search

GwtMaterialDesign / gwt-material-table

A complex table component designed for the material design specifications
https://gwtmaterialdesign.github.io/gmd-table-demo/
Apache License 2.0
27 stars 31 forks source link

Enhance performance with tables with large number of pages. #149

Closed l-dobrev closed 6 years ago

l-dobrev commented 6 years ago

Fix bad performance by not reloading the page-selection drop-down constantly when building it, but rather reload it after adding all the pages. Fixes #148

BenDol commented 6 years ago

Nice catch! Appreciate the contribution. Can you please create the PR against release_2.1 branch?

BenDol commented 6 years ago

Also, do we need to refresh the list after the loop?

l-dobrev commented 6 years ago
  1. I was hoping for this to be included in 2.0.2, I will create a new PR for release_2.1
  2. Technically we need to refresh the list after adding the options, but the setSelectedIndex() does it for us.
l-dobrev commented 6 years ago

Actually no need to PR against 2.1 since (I checked) it does not use a drop-down, but a text/integer field.

kevzlou7979 commented 6 years ago

@l-dobrev Correct the pager was replaced recently with text field instead of dropdown. This could be added on 2.1 release

kevzlou7979 commented 6 years ago

We saw a benifit also for this using dropdown, we could enable two-way feature using text-input and dropdown

BenDol commented 6 years ago

We should create a new issue for dropdown Pager support.