GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
411 stars 124 forks source link

MaterialTextBox and MaterialTextArea are missing the method to set label text color #1005

Open andreififiita opened 3 years ago

andreififiita commented 3 years ago

Version 2.5.0:

Because text widgets getLabel() method won't return Label class, the methid getLabel().setTextColor() cannot be used. Please provide a new method setLabelTextColor to set the label custom color.

kevzlou7979 commented 3 years ago

This is a good feature to have will update it

On Wed, May 5, 2021, 4:30 PM AndreiF, @.***> wrote:

Version 2.5.0:

Because text widgets getLabel() method won't return Label class, the methid getLabel().setTextColor() cannot be used. Please provide a new method setLabelTextColor to set the label custom color.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material/issues/1005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EFZLI7DPXTZFVR2IS3DTMD6ZNANCNFSM44EG3UQA .

andreififiita commented 3 years ago

Thanks! It would be great if it would be in the next 2.5.0 (or .1) candidate.

kevzlou7979 commented 3 years ago

Ok I have provided a way to get the Label widget from MaterialValueBoxes thru valueBox.getFieldLabel()

andreififiita commented 3 years ago

I think there is (and was) already a method called valueBox.getLabel(), but it was made private. I don't think there should be 2 methods.