search

GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
410 stars 124 forks source link

Allow MaterialAnimation to accept a CSS name or a Transition object instead of just a Transition object #1009

Open timmattison opened 3 years ago

timmattison commented 3 years ago

I would like to use the MaterialAnimation class to handle some custom animations but MaterialAnimation depends on the Transition enum. Since enums cannot be extended I can't find a way to get my animation's CSS name in there without modifying GWT Material itself. Is there another way?

If not, I'll try to submit a PR for it.

kevzlou7979 commented 3 years ago

For now we dont support a css name, sure you can submit a pull request then we can review.

On Fri, Jul 2, 2021, 10:23 AM Tim Mattison, @.***> wrote:

I would like to use the MaterialAnimation class to handle some custom animations but MaterialAnimation depends on the Transition enum. Since enums cannot be extended I can't find a way to get my animation's CSS name in there without modifying GWT Material itself. Is there another way?

If not, I'll try to submit a PR for it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material/issues/1009, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EFZZJSYCZDYDFTXLKUDTVUPLDANCNFSM47V2IFJA .

timmattison commented 3 years ago

Sorry, I gave it a shot with no luck. I'll try again today but it's a bit more involved than I thought.

timmattison commented 3 years ago

It's inheriting the new module I created that's giving me a problem. If you can point me to any guidance on a good way to set this library so I can develop with it on my own and get the XML inherits and Maven setup right please let me know and I'll keep trying.