search

GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
410 stars 124 forks source link

PushManager.permissionState() not working on Chrome #1016

Open ingosch opened 2 years ago

ingosch commented 2 years ago

Calling perissionState() without userVisibleOnly parameter raises an exception:

Uncaught (in promise) DOMException: Push subscriptions that don't enable userVisibleOnly are not supported.

https://developer.mozilla.org/en-US/docs/Web/API/PushManager/permissionState

Solution: simply add PushSubscriptionOptions as parameter to permissionState function in PushManager wrapper class.

kevzlou7979 commented 2 years ago

Hi there,

You can submit PR I think then we can test it or we can patch this change.

Thanks, GMD Team

On Mon, Sep 13, 2021 at 9:14 PM ingosch @.***> wrote:

Calling perissionState() without userVisibleOnly parameter raises an exception:

Uncaught (in promise) DOMException: Push subscriptions that don't enable userVisibleOnly are not supported.

https://developer.mozilla.org/en-US/docs/Web/API/PushManager/permissionState http://url

Solution: simply add PushSubscriptionOptions as parameter to permissionState function in PushManager wrapper class.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material/issues/1016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EF766O2YYTKNRHMZAXDUBX2KXANCNFSM5D5ZQFDQ .