GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
411 stars 124 forks source link

Upgrade materialize.js to v1.0.0 or v2.x #1036

Open squinn opened 1 year ago

squinn commented 1 year ago

I'm a big fan of GMD, thank you all your continued efforts to keep this project up to date! I'm running into an issue in one of my applications where I'd like to take advantage of the new "container" option that the "Dropdown" widget now supports in the materialize.js library. (See: https://materializecss.com/dropdown.html)

I tried to force it in, but because the "gwt.material.design.client.resources.MaterialResources.java" class currently references the "materialize-0.97.5.min.js" file I'm running into conflicts.

Would you consider upgrading the materialize JS library to 1.0.0 in an upcoming release of the core gwt-material jar?

squinn commented 1 year ago

Interesting, I just ran across what appears to be a 2.x version materialize JS library here as well:

https://materializeweb.com/

If that version is more actively maintained, perhaps that would be a better version to switch over to for GMD.

kevzlou7979 commented 1 year ago

This is interesting we would need to review the 2.x use cases, there might be some huge refactor on how we execute JS initializations , functions and properties.

On Sat, 10 Jun 2023, 3:08 am Shawn Quinn, @.***> wrote:

Interesting, I just ran across what appears to be a 2.x version materialize JS library here as well:

https://materializeweb.com/

If that version is more actively maintained, perhaps that would be a better version to switch over to for GMD.

— Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material/issues/1036#issuecomment-1585021929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EFZRN4LAZZ6BTLXNEMLXKNYELANCNFSM6AAAAAAX6RXR34 . You are receiving this because you are subscribed to this thread.Message ID: @.***>