search

GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
410 stars 124 forks source link

Lighthouse score for GWT-Material apps decreased due to unload listener in older embedded JQuery #1043

Open garthhenning opened 4 months ago

garthhenning commented 4 months ago

Google Lighthouse now scores use of an unload listener poorly for their "Best Practices" score. 

   https://web.dev/articles/bfcache?utm_source=lighthouse&utm_medium=devtools#never_use_the_unload_event

GWT-Material v2.8.3 has an embedded dependency on JQuery v3.5.1. JQuery v3.5.1 attaches unload listeners. JQuery corrected this in v3.7.1. 

   https://github.com/jquery/jquery/issues/5323

Updating the embedded JQuery would mean web sites using GWT-Material no longer get their scores decremented.

kevzlou7979 commented 4 months ago

Nice catch will check into it

On Wed, 21 Feb 2024, 12:47 pm Garth Henning, @.***> wrote:

Google Lighthouse now scores use of an unload listener poorly for their "Best Practices" score.

https://web.dev/articles/bfcache?utm_source=lighthouse&utm_medium=devtools#never_use_the_unload_event

GWT-Material v2.8.3 has an embedded dependency on JQuery v3.5.1. JQuery v3.5.1 attaches unload listeners. JQuery corrected this in v3.7.1.

https://github.com/jquery/jquery/issues/5323

Updating the embedded JQuery would mean web sites using GWT-Material no longer get their scores decremented.

— Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material/issues/1043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EF6BUDNCT3BJJ7LBYRDYUV37RAVCNFSM6AAAAABDSLEFY6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DKOBSGY2DSMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>