search

GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
410 stars 124 forks source link

clearHelperText() not working #996

Closed c-kob closed 3 years ago

c-kob commented 3 years ago

The clearHelperText() method in the StatusTextMixin is not working, i.e. the helper text is not being removed (whether called directly or through clearStatusText()) The code for this method differs from clearErrorText() and clearSuccessText(), both of which are working as expected (but call applyHelperText() at the end).

kevzlou7979 commented 3 years ago

Will review this, as the helper text must be visible all the time but yeah it might be good for us to be able to remove the helper text.

c-kob commented 3 years ago

Thanks. Maybe just set to empty string (which of course can also be done explicitly)? Or remove the method to avoid confusion.

kevzlou7979 commented 3 years ago

Yeah, we are accepting pull request feel free to create one

On Sun, Jan 3, 2021, 5:10 PM c-kob, notifications@github.com wrote:

Thanks. Maybe just set to empty string (which of course can also be done explicitly)? Or remove the method to avoid confusion.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/GwtMaterialDesign/gwt-material/issues/996#issuecomment-753588580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6EF7CNZETFSWE34BQLIDSYAX65ANCNFSM4VQGAZZA .

kevzlou7979 commented 3 years ago

Patched via https://github.com/GwtMaterialDesign/gwt-material/commit/6a7aa5254340de2b452e7b8be1317592b834db45

kevzlou7979 commented 3 years ago

Will be adding a unit test for this change especially for StatusTextMixin also note we are standardizing our unit test for all mixins.

kevzlou7979 commented 3 years ago

Test Case was added via https://github.com/GwtMaterialDesign/gwt-material/commit/f26f37d0f60187609eb38d81718a520087270c7d