search

GwtMaterialDesign / gwt-material

A Google Material Design wrapper for GWT
https://gwtmaterialdesign.github.io/gmd-core-demo/
Apache License 2.0
410 stars 124 forks source link

Issue #996 #997

Closed c-kob closed 3 years ago

c-kob commented 3 years ago

changed clearHelperText() to set local variable helperText to empty string and then call hideHelperText() private method hideHelperText() contains the code from the previous clearHelperText method and is called instead of clearHelperText() from setErrorText() and setSuccessText()

This ensures that helperText will be reinstated when error or success text is removed (eg after successful validation) unless it has been cleared

kevzlou7979 commented 3 years ago

Thanks for the PR.

kevzlou7979 commented 3 years ago

Will be creating a junit test for this also. Patched 2.5.0-SNAPSHOT https://github.com/GwtMaterialDesign/gwt-material/commit/6a7aa5254340de2b452e7b8be1317592b834db45