Gyoo / LiveSplit.SplitsBet

GitHub for the LiveSplit plugin SplitsBet, the bot that makes the viewers play with the runner
8 stars 10 forks source link

Allow switching between GameTime and RealTime. #11

Closed 0x0ade closed 9 years ago

0x0ade commented 9 years ago

Still requires a setting to do that without recompiling the component.

CryZe commented 9 years ago

I do not approve. LiveSplit allows you to just use the Current Timing Method, which is more than enough. You can have a setting that overrides the Current Timing Method, but it shouldn't use the setting by default.

0x0ade commented 9 years ago

Good to know that's possible. I just did that because I've seen references to RealTime in the original code and thus added the possibility to switch between RealTime and GameTime instead of always using RealTime.

I still need to take a deeper look into LiveSplit.

CryZe commented 9 years ago

I guess you can modify GetTime to get the state too and then you can do something like this:

TimingMethod timingMethod;
if (OverrideTimingMethod)
  timingMethod = OverriddenTimingMethod;
else
  timingMethod = State.CurrentTimingMethod;

return segment[timingMethod];
0x0ade commented 9 years ago

Instead of using two properties, one being a boolean and another being the timing method, I'm using a nullable. Other than that, thanks for pointing out State.CurrentTimingMethod

Gyoo commented 9 years ago

State.CurrentTimingMethod might just be the ansyer to what I asked to Cryze this morning on Skype... If so, I'm dumb as a brick.

Gyoo commented 9 years ago

Shall I merge this or there's more to come ?

0x0ade commented 9 years ago

If @CryZe can't find more issues, then I've got nothing to add.