H-A-Dye / DataQuilt

Data quilts - program to create data based quilts
MIT License
4 stars 0 forks source link

27 add pdf download/summary df to app #30

Closed heatheranndye closed 1 year ago

heatheranndye commented 1 year ago

The program is functional. I can't get the picture to go into the borb function so I have a place holder, but I will figure it out eventually.

I am not sure what to do about the token issue and NOAA replied "we sent you one" - but it is the same one.

The next step is more refactoring and making the app look nice.

heatheranndye commented 1 year ago

On speed: there are two slow points - the data request from NOAA and the pdf document.

  1. I structured the data request from NOAA to call 10 weather stations and then go through and look for one with a complete set of data. I used my zip code while I was writing the code - turns out I had to go through a high number of data sets to get a complete one. I think I can restructure to call a station and check, but that involves rewrites in data_from_api. I can do that after the issues above, although I'd want to do a commit before this restructure.
  2. The pdf - constructing a pdf is just slow. I don't think there is anything to be done here.