Closed dpogue closed 11 years ago
This is mostly done at this point - plClient and a couple of other apps are converted, along with the max plugin. Someone should probably play with the remaining apps at some point, just so we can finally close this thing
I think the only remaining blocker on this is plSDLBrowser
Awesome. It'll be nice to finally close #1
I tried to write a CMake file for it once but I encountered either a problem with missing files or one with outdated code.
Some of the code files were removed in an old commit as they were unused at the time. I'm planning to try to get it to work later today.
Edit : it seems some files needed were removed for licence issues, namely https://bitbucket.org/Lunanne/cwe-ou/src/d2e5b9c38803/MOULOpenSourceClientPlugin/Plasma20/Sources/Plasma/PubUtilLib/plWndCtrls/basewnd.h
Did you make any progress on that, @Lunanne, or should I take a stab at it?
I haven't really looked again, I got distracted and I don't really know enough c++ yet to solve the issue anyway.
It appears to have been commit 971c39d92 which removed those files due to a dependency upon a library with no license (at least none that I can see on http://www.mvps.org/user32/), but the plWndCtrls code itself should have been fine...? It seems the code on which it depended was a very simple collection of functions to replace, too, but it was all unused at the time since plSDLBrowser was not active.
Do we even need to resurrect plSDLBrowser? Looking at this thing, it appears pretty simple and ugly, and depends on a load of gunk used nowhere else.
My thoughts here:
Is there a need for this sort of tool in the community? If so we either need to fix this or write a replacement. If there's no present need it should be trashed and only looked at again if we have a need that this tool (or something like it) could fill.
gah, freeking close and comment is not awesome on un-css'd browsers :(
I'm currently trying to get the project to build to see what it exactly does, probably anyone else can do this a lot faster than me but it is a good exercise.
IRC discussion has led to the consensus that plSDLBrowser should be tossed, because it is useless as it is and can't work because of removed copyrighted Microsoft code. I'll try to make a PR removing it.
This will also allow generation of Makefiles, XCode projects, and MinGW makefiles.