search

H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
205 stars 81 forks source link

Add support for GameMgr based Blue Spiral Games. #1309

Closed Hoikas closed 1 year ago

Hoikas commented 1 year ago

Adds support for legacy Blue Spiral games (eg MOULa).

Depends on #1308, #1217.

The BlueSpiral Python is quite a bit simpler than the marker game Python, so I am willing to re-order the PRs such that the BlueSpiral commit comes before the marker commit, allowing this PR to be reviewed and merged before #1217. These three PRs are all one branch on my machine, FWIW.

This PR introduces a minor change to the BlueSpiral gameplay logic, which will be upstreamed to OU soon. On Cyan's variant of BlueSpiral, clicking the bahro door while a game is running is supposed to start a new game. On H'uru, clicking on the bahro door while a game is running is disabled. In this PR, clicking on the bahro door while a game is running causes the current game to end as if someone had pressed an incorrect cloth. This change was made because Cyan's restart game functionality is buggy, and clicking on the door many times in quick succession yields comical results.

This requires H-uru/moul-assets#219.

Hoikas commented 1 year ago

Suggestions about the CI failures would be appreciated.

Hoikas commented 1 year ago

Converting to draft status based on observations from today's private test.

Hoikas commented 1 year ago

All known problems fixed; we're ready for review.

Hoikas commented 1 year ago

I've re-ordered the commits so that this PR no longer depends on #1217.

Hoikas commented 1 year ago

Rebased to fix merge conflicts.