H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
205 stars 80 forks source link

Migrate plLocalization to `ST::string` #1367

Closed dgelessus closed 1 year ago

dgelessus commented 1 year ago

And remove some unused and/or obsolete methods.

The changes touch a few parts of the Max plugin, which I cannot test properly, as usual.

This class could use some further cleanup too:

zrax commented 1 year ago

Looks like plInputMap.cpp is missing an <algorithm> include, exposed by header include changes here

dgelessus commented 1 year ago

Ah, thanks for the heads-up. This wasn't noticeable on Windows, because hsWindows.h includes <algorithm>. Pushed a fix to #1358 - to avoid causing merge conflicts, because that PR already touches the plInputMap.cpp includes.

Hoikas commented 1 year ago

I think this needs to be rebased to fix the two CI failures.