H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
205 stars 80 forks source link

Update vcpkg to 2023.07.21 #1444

Closed dpogue closed 1 year ago

dpogue commented 1 year ago

Also make sure we get (older) working versions of a few dependencies.

Port Version Changes

dpogue commented 1 year ago

@Hoikas Do we need the -plasma triplets for Windows or is it okay to use overlay triplets and just re-declare x64-windows.cmake and x86-windows.cmake with our modifications?

Hoikas commented 1 year ago

I don't think hiding any of the official triplets (eg x86-windows, x64-osx) is a good idea. I'm not certain that vcpkg allows overlay triplets to mask official triplets in this way. If it does, however, in my mind, the official triplets have a well understood output by the C++ community. Changing that output seems like a gotcha. After all, VCPKG_TARGET_TRIPLET is still a user-configurable option in CMake, we just put our opinion on things to make certain libraries build in the way that we prefer. The official Windows triplets produce perfectly working libraries for us, just not in our preferred linkage. So, I don't see why we should hide something that works perfectly fine.

dpogue commented 1 year ago

It appears (based on how the macOS triplets are working here) that overlay triplets work the same way as overlay ports and mask the official ones.

That said, if we prefer to keep our triplets with a suffix, then I'll figure out how best to do that for the macOS ones as well.