H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
205 stars 81 forks source link

Fix an unlikely corner case of backwards compatibility with older clients #1445

Closed zrax closed 1 year ago

zrax commented 1 year ago

The previous broken StrCopy used in the older implementation of CryptHashPassword would only write the trailing '\0' character if the copied string had a size greater than zero. This change ONLY affects empty usernames and passwords, which is basically useless for anything other than testing (however, it can get DirtSand into a bad state -- see the PR there for details).