H-uru / Plasma

Cyan Worlds's Plasma game engine
http://h-uru.github.io/Plasma/
GNU General Public License v3.0
203 stars 80 forks source link

Adds SDL based upload check for imagers #1458

Closed Hazado closed 9 months ago

Hazado commented 1 year ago

Assets - https://github.com/H-uru/moul-assets/pull/241 Sets up the an SDL variable so you can set individual permissions for upload/pellet drops to everyone/member only/off

Requested by Cyan Shard operator to prevent pellet uploads in individual hoods

Adds new SDL variable to Neighborhood.sdl nb01PelletUploadState

0 <= Everyone can upload (Default) 1 = Members only upload 2 >= No one can upload

dgelessus commented 1 year ago

Relatively minor thing: the code looks like it would work for all imagers that pop up in the KI, not just the pellet imager. Perhaps the things in the script should be called ImagerPermissionVariable, CheckPermission, etc. instead, in case we later want to add permission checks to other imagers as well?

Hazado commented 1 year ago

Relatively minor thing: the code looks like it would work for all imagers that pop up in the KI, not just the pellet imager. Perhaps the things in the script should be called ImagerPermissionVariable, CheckPermission, etc. instead, in case we later want to add permission checks to other imagers as well?

Your absolutely right, change made.

Hoikas commented 1 year ago

As of #1450, we could theoretically merge this immediately without breaking MOULa. However, I think there's probably a discussion to be had about what our repository's SDL should look like compared to the rest of the ecosystem, so we should probably wait until either after that discussion or the SDL is deployed to MOULa.