hsMessageBox Cleanups - Githubissues

H-uru / Plasma

Cyan Worlds's Plasma game engine

http://h-uru.github.io/Plasma/

GNU General Public License v3.0

203 stars 80 forks source link

hsMessageBox Cleanups #1466

Closed dpogue closed 11 months ago

dpogue commented 1 year ago

Moves hsMessageBox implementation out of CoreLib and into PubUtilLib
Splits the Win32-specific implementation into its own file (matching how macOS is handled)
Adds overloads for hsMessageBox that take ST::string
Silences (on gcc & clang) deprecation warnings from OpenSSL about RC4

I'm unsure on whether it makes sense to change the hsMessageBox stuff to always convert to ST::string and then have a single implementation, or if it's more performant having it split up as it currently is...

dgelessus commented 1 year ago

Not something that needs to be done in this PR, but I think it would make sense to pull hsMessageBox out into its own header. Possibly even into another library, somewhere under PubUtilLib. If my search is correct, hsMessageBox isn't called anywhere in CoreLib or NucleusLib, so it would be great if we could build those libraries without depending on GUI libraries for no reason.

dpogue commented 1 year ago

I think it would make sense to pull hsMessageBox out into its own header. Possibly even into another library, somewhere under PubUtilLib.

I like this idea